Fix bootimage build #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis claims the bootimage build is working just fine: https://travis-ci.org/ReadyTalk/avian What platform(s) are you having trouble on? |
|
Without the patch, I mean: https://travis-ci.org/ReadyTalk/avian/builds/4837711 |
|
I was building on darwin-x86_64; given the changes in the patch, I don't know how it's building unless those same changes already made their way into the repo. I'll investigate. |
|
On Tue, 19 Feb 2013, Joshua Warner wrote:
Did you have |
|
Oops... You're right. I should have pulled to make sure you didn't already fix it. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bootimage build (specifically, bootimage.cpp) was broken in the wake of the recent codegen namespace reorganization. This fixes the errors.